-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Set storage update time in FakeStorageRpc #174
fix: Set storage update time in FakeStorageRpc #174
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
Codecov Report
@@ Coverage Diff @@
## master #174 +/- ##
============================================
+ Coverage 71.71% 72.21% +0.50%
- Complexity 495 499 +4
============================================
Files 29 29
Lines 1658 1663 +5
Branches 268 268
============================================
+ Hits 1189 1201 +12
+ Misses 344 336 -8
- Partials 125 126 +1
Continue to review full report at Codecov.
|
bab6f0e
to
a9493a4
Compare
a9493a4
to
2c1ca3f
Compare
@chingor13 @frankyn thanks! |
# Conflicts: # google-cloud-nio/src/main/java/com/google/cloud/storage/contrib/nio/testing/FakeStorageRpc.java
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #173